Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jayhwang sc 86422 implement magic wallet sendgaslesstxn #622

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Jayhwang sc 86422 implement magic wallet sendgaslesstxn #622

merged 6 commits into from
Sep 14, 2023

Conversation

octave08
Copy link
Contributor

@octave08 octave08 commented Sep 12, 2023 •
edited by github-actions bot
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

added sendGaslessTransaction method
added gasEndpoint to magid-sdk config so that you can test sendGaslessTransaction wherever you want envs

removed nftEndpoint

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #86422: Implement magic.wallet.sendGaslessTxn.

@octave08 octave08 marked this pull request as ready for review September 12, 2023 23:43
@octave08 octave08 self-assigned this Sep 12, 2023
@octave08 octave08 added the minor Increment the minor version when merged label Sep 12, 2023
@octave08 octave08 force-pushed the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch from 9ba6a5c to 7e3ad93 Compare September 13, 2023 00:50
karljin
karljin previously approved these changes Sep 13, 2023
View reviewed changes
@octave08 octave08 force-pushed the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch from 7e3ad93 to 898d5d1 Compare September 13, 2023 04:58
@octave08 octave08 force-pushed the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch 2 times, most recently from 25ac521 to 7e34974 Compare September 13, 2023 11:45
@octave08 octave08 force-pushed the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch from 7e34974 to e0cccac Compare September 13, 2023 11:55
@octave08 octave08 force-pushed the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch from 8037e46 to 6d73e54 Compare September 13, 2023 22:03
@octave08 octave08 added this pull request to the merge queue Sep 14, 2023
Merged via the queue into master with commit e126ccd Sep 14, 2023
@octave08 octave08 deleted the jayhwang-sc-86422-implement-magic-wallet-sendgaslesstxn branch September 14, 2023 00:24
@Ariflo
Copy link
Contributor

Ariflo commented Sep 14, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsuresh2020 sandeepsuresh2020 sandeepsuresh2020 approved these changes

@karljin karljin karljin left review comments

Assignees

@octave08 octave08

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octave08 @Ariflo @karljin @sandeepsuresh2020