Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nft.transfer api #602

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Implement nft.transfer api #602

merged 2 commits into from
Aug 8, 2023

Conversation

ysm-dev
Copy link
Contributor

@ysm-dev ysm-dev commented Aug 7, 2023 •
edited by github-actions bot
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@ysm-dev ysm-dev requested review from karljin and octave08 August 7, 2023 11:31
@ysm-dev ysm-dev self-assigned this Aug 7, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #83347: [NFT Transfer] implement nft.transfer api.

karljin
karljin requested changes Aug 7, 2023
View reviewed changes
packages/@magic-sdk/provider/src/modules/nft.ts Outdated
@@ -20,4 +21,10 @@ export class NFTModule extends BaseModule {
const requestPayload = createJsonRpcRequestPayload(MagicPayloadMethod.NFTCheckout, [options]);
return this.request<NFTCheckoutResponse>(requestPayload);
}

/* Start an NFT Transfer flow with Paypal */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transfer has nothing to do with paypal. let's change this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acf2eea

@octave08 octave08 marked this pull request as ready for review August 8, 2023 15:07
@octave08 octave08 changed the title [WIP] Implement nft.transfer api Implement nft.transfer api Aug 8, 2023
@octave08 octave08 added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit cd567fd Aug 8, 2023
@octave08 octave08 deleted the chris.yang-sc-83347-nft-transfer-implement-nft-transfer-api branch August 8, 2023 15:18
@Ariflo
Copy link
Contributor

Ariflo commented Aug 8, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karljin karljin karljin approved these changes

@octave08 octave08 octave08 approved these changes

Assignees

@ysm-dev ysm-dev

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysm-dev @Ariflo @karljin @octave08