Jerryliu sc 81984 update loginwithemailotp interface with new

[Ethella]

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

• [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

• patch: Bug Fix?
• minor: New Feature?
• major: Breaking Change?
• skip-release: It's unnecessary to publish this change.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

[shortcut-integration]

This pull request has been linked to Shortcut Story #81984: update loginWithEmailOTP interface with new param deviceCheckUI.

[Ariflo]

Can you confirm that this change will not affect our Native SDK's implementation of loginWithEmailOTP? I'm a little traumatized by the last time we messed with this code: https://www.notion.so/magiclabs/Email-OTP-Modal-was-Hidden-on-Native-Mobile-SDK-s-Due-To-Magic-SDK-Update-301ccd9a74bb4de9abe63697ce4ba149?pvs=4

[Ethella]

Can you confirm that this change will not affect our Native SDK's implementation of loginWithEmailOTP? I'm a little traumatized by the last time we messed with this code: https://www.notion.so/magiclabs/Email-OTP-Modal-was-Hidden-on-Native-Mobile-SDK-s-Due-To-Magic-SDK-Update-301ccd9a74bb4de9abe63697ce4ba149?pvs=4

Yes, thx for bringing that up. The deviceCheckUI is expected to be nullable and will default to true. So logically, it won't affect mobile SDK. I'll make sure it's been tested once we ship the change in auth relayer

[Ariflo]

WFM 👍