Add optional nftEndpoint param #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #81912: add optional nftEndpoint param. |
karljin
previously approved these changes
Jul 20, 2023
octave08
commented
Jul 20, 2023
Comment on lines
+25
to
+36
| test('Generate JSON RPC request payload with method `magic_get_info`', async () => { | ||
| const magic = createMagicSDK(); | ||
| magic.user.request = jest.fn(); | ||
|
|
||
| await storage.setItem('mc_active_wallet', 'metamask'); | ||
|
|
||
| await magic.user.getInfo(); | ||
|
|
||
| const requestPayload = magic.user.request.mock.calls[0][0]; | ||
| expect(requestPayload.method).toBe('magic_get_info'); | ||
| expect(requestPayload.params).toEqual([{ walletType: 'metamask' }]); | ||
| }); |
There was a problem hiding this comment.
This code is not related to this PR, but it helps this PR to pass the coverage threshold.
bengriffin1
previously approved these changes
Jul 20, 2023
Ariflo
dismissed
bengriffin1’s stale review
The merge-base changed after approval.
octave08
force-pushed
the
jayhwang-sc-81912-add-optional-nftendpoint-param
branch
from
77b5206 to
f5fea52
Compare
|
@Ariflo thanks for letting me know btw |
@octave08 we believe it's currently failing due to a recent change to our CI authentication token. Infra is currently in process of getting it fixed. Hoping this get resolved today, if not early tomorrow. |
bengriffin1
approved these changes
Jul 21, 2023
karljin
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
Create a magic instance with
nftEnpointparam so that internal developers point to nft-api endpoint they want✅ Fixed Issues
Add
nftEndpointparam in SDK config🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: