Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit id token on connect #564

Merged
merged 17 commits into from
Jul 7, 2023
Merged

Emit id token on connect #564

merged 17 commits into from
Jul 7, 2023

Conversation

Dizigen
Copy link
Contributor

@Dizigen Dizigen commented Jul 7, 2023 •
edited by magiclabsFE
Loading

📦 Pull Request

  • Emit id-token-created on provider.enable and wallet.connectWithUI
  • Refactor connectWithUI to be a PromiEvent so the id-token-created event can be remitted and caught.
  • Update provider.enable to send mc_login instead of eth_getAccounts

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

Dizigen added 17 commits June 23, 2023 12:43
@Dizigen
add id-token-created event to provider.enable
11e6051
@Dizigen
register ProviderEnableEvents in function contract
d2a8eec
@Dizigen
update provider enable to do mc_login
24dc29d
@Dizigen
Merge branch 'master' into provider-enable-token-event
09df971
@Dizigen
update yarn.lock
5c3f21e
@Dizigen
fix provider enable test
2002403
@Dizigen
register event types for connectWithUi
dadccae
@Dizigen
Merge branch 'master' into provider-enable-token-event
abcbe38
@Dizigen
register wallet types in index.ts
10eaea0
@Dizigen
move ConnectWithUiEvents to wallet.ts
bf6eb47
@Dizigen
remove async elements of connectWithUi to test promi events
08461f7
@Dizigen
convert connectWithUI to promiEvent
8562cb1
@Dizigen
re-emit id-token-created
108bc55
@Dizigen
fix unit tests
5c28c6e
@Dizigen
add return statements to auto-resolved third party wallet connections
72023e7
@Dizigen
Merge branch 'master' into provider-enable-token-event
8dd79b2
@Dizigen
update yarn lock
c041c00
@Dizigen Dizigen requested review from Ariflo and Ethella July 7, 2023 16:42
@Dizigen Dizigen self-assigned this Jul 7, 2023
@Dizigen Dizigen added the patch Increment the patch version when merged label Jul 7, 2023
Ariflo
Ariflo approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for Jerry's PR to finish running before merging this one. Thanks!

@Dizigen Dizigen merged commit 667982a into master Jul 7, 2023
@Dizigen Dizigen deleted the emit-id-token-on-connect branch July 7, 2023 20:07
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@Dizigen Dizigen

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dizigen @magiclabsFE @Ariflo