Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerryliu sc 74424 email otp login invalid email otp event #487

Merged

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Mar 30, 2023

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

add cancel events to emailOTP whitelabel

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ethella Ethella self-assigned this Mar 30, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #74424: Email OTP Login - invalid-email-otp Event.

@Ethella Ethella added the minor Increment the minor version when merged label Mar 30, 2023
@Ethella Ethella added major Increment the major version when merged and removed minor Increment the minor version when merged labels Mar 30, 2023
@Ethella
Copy link
Member Author

Ethella commented Mar 30, 2023

Change it to major as it introduces breaking change to loginWithEmailOtp whitelabel

@Ethella Ethella force-pushed the jerryliu-sc-74424-email-otp-login-invalid-email-otp-event branch from 5340888 to d2dbc0d Compare March 31, 2023 04:44
@Ethella Ethella merged commit 1450b3c into master Mar 31, 2023
@Ethella Ethella deleted the jerryliu-sc-74424-email-otp-login-invalid-email-otp-event branch March 31, 2023 16:25
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants