-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@react-native-community/async-storage
=> @react-native-async-storage/async-storage
in RN Bare Package
#479
@react-native-community/async-storage
=> @react-native-async-storage/async-storage
in RN Bare Package
#479
Conversation
This pull request has been linked to Shortcut Story #72161: @react-native-bare - clean up devDependencies and peerDependencies - BTC Magazine. |
@react-native-community/async-storage
=> @react-native-async-storage/async-storage
in RN Bare Package
Is it tested? |
yes with magiclabs/react-native-demo#43 |
19c99bc
to
1ac8e19
Compare
π PR was released in |
Hi, It looks like the submitter's local test didn't work and the requester acknowledged that the app wasn't running magiclabs/react-native-demo#43 (comment). I don't know if that entirely necessitates a revert but might be worth it to keep Even before this, there is something odd going on with the async storage where it crashes apps in production but not when running off an expo server
This is happening on an Android emulator Pixel_5_API_31 but my FlightTest iOS app on 16.0.3 also crashes with a memory exception at 0x0 w/o anymore of a useful error but doesn't when I remove the Magic-SDK entirely so it seems to indicate something is wrong with the package. That's all to say, maybe this will fix this issue, maybe not but something weird with asyncstorage is definitely already happening. |
Hi @madelinecameron, thanks for reaching out; it turns out that the issue I mentioned on magiclabs/react-native-demo#43 (comment) wasn't related to this update away from That said, we're working to resolve the issue asap and in the meantime have unpublished the new version of the sdks. For now, please point you expo based application to Please do continue to let us know if you still run into issues. Fwiw, the |
π¦ Pull Request
@react-native-community/async-storage
has been deprecated and replaced by@react-native-async-storage/async-storage
. This updates our dependencies to match the update.β Fixed Issues
n/a
π¨ Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.