move third party wallet connections to sdk #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattupham
reviewed
Mar 21, 2023
mattupham
reviewed
Mar 21, 2023
packages/@magic-sdk/provider/test/spec/modules/wallet/connectToCoinbaseWallet.spec.ts
Show resolved
Hide resolved
mattupham
previously approved these changes
Mar 21, 2023
bcleary06
reviewed
Mar 21, 2023
mattupham
previously approved these changes
Mar 22, 2023
bcleary06
previously approved these changes
Mar 23, 2023
mattupham
previously approved these changes
Mar 23, 2023
bcleary06
approved these changes
Mar 24, 2023
Ariflo
added a commit
that referenced
this pull request
Mar 27, 2023
…connect-updates Revert "move third party wallet connections to sdk (#473)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
thirdPartyWalletOptionsto the Magic constructor options (required if using Magic Connect with Coinbase Wallet or Wallet Connect enabled)magic.wallet.getProvider()method that returns the provider of the active wallet✅ Fixed Issues
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.