Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing for metadata phone number #225

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

dgerrellsMagic
Copy link
Contributor

πŸ“¦ Pull Request

Adding typings for phone number in meta data

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #45294: FE - add phone number to getInfo and expose to magic sdk.

@dgerrellsMagic dgerrellsMagic added the minor Increment the minor version when merged label Oct 8, 2021
@dgerrellsMagic dgerrellsMagic requested a review from smithki October 8, 2021 19:17
@dgerrellsMagic dgerrellsMagic added patch Increment the patch version when merged minor Increment the minor version when merged and removed minor Increment the minor version when merged labels Oct 8, 2021
@dgerrellsMagic dgerrellsMagic merged commit 1c5aafd into master Oct 8, 2021
@dgerrellsMagic dgerrellsMagic deleted the dgerrells-ch45294-add-phonenumber-typing branch October 8, 2021 22:11
@smithki smithki added the released This issue/pull request has been released. label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants