Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bypass webcrypto on non web platforms #200

Merged
merged 1 commit into from
Sep 1, 2021
Merged

bypass webcrypto on non web platforms #200

merged 1 commit into from
Sep 1, 2021

Conversation

dgerrellsMagic
Copy link
Contributor

📦 Pull Request

Ignore calling webcrypto apis if not web platform

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@dgerrellsMagic dgerrellsMagic added the minor Increment the minor version when merged label Sep 1, 2021
@dgerrellsMagic dgerrellsMagic self-assigned this Sep 1, 2021
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #43464: FE - silence logs for webcrypto on react native platform.

@dgerrellsMagic dgerrellsMagic merged commit 2f7cbc7 into master Sep 1, 2021
@dgerrellsMagic dgerrellsMagic deleted the dgerrells-ch43464-bypass-webcrypto-on-react-native branch September 1, 2021 20:46
@Ethella Ethella self-requested a review September 2, 2021 02:01
@smithki smithki added the released This issue/pull request has been released. label Sep 2, 2021
@smithki smithki added the prerelease This change is available in a prerelease. label Sep 17, 2021
@smithki
Copy link
Contributor

smithki commented Sep 17, 2021

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabs magiclabs deleted a comment from shortcut-integration bot Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithki smithki smithki approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@dgerrellsMagic dgerrellsMagic

Labels
minor Increment the minor version when merged prerelease This change is available in a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgerrellsMagic @smithki