Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test-mode prefix to Ethereum RPC methods #181

Merged
merged 2 commits into from
May 4, 2021
Merged

Add test-mode prefix to Ethereum RPC methods #181

merged 2 commits into from
May 4, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 27, 2021

📦 Pull Request

This PR adds a prefix (testMode/eth/) to Ethereum RPC methods so they can be specifically handled for Magic SDK's testMode feature.

🚨 Test instructions

yarn test

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@smithki smithki added the minor Increment the minor version when merged label Apr 27, 2021
@smithki smithki self-assigned this Apr 27, 2021
@smithki smithki requested a review from Ethella April 27, 2021 00:31
@smithki
Copy link
Contributor Author

smithki commented Apr 27, 2021

Will wait for the Magic <iframe> to be updated with support for this change before merging/publishing this PR.

@smithki smithki marked this pull request as ready for review May 4, 2021 17:07
@dgerrellsMagic dgerrellsMagic merged commit 68203f9 into master May 4, 2021
@dgerrellsMagic dgerrellsMagic deleted the smithki-ch37434-test-mode-eth-methods branch May 4, 2021 17:09
@smithki
Copy link
Contributor Author

smithki commented May 4, 2021

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerrellsMagic dgerrellsMagic dgerrellsMagic approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@smithki smithki

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithki @dgerrellsMagic