Merge pull request #852 from magiclabs/fix-build

chore: migrate upload-artifact to v4
magiclabs · Jan 30, 2025 · 5b1b58e · 5b1b58e
2 parents 4b684ac + 1aa37cb
commit 5b1b58e
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 58 deletions.
diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml
@@ -2,7 +2,7 @@ name: Canary
 on:
   pull_request:
     branches:
-      - "master"
+      - 'master'
   merge_group:
     types: [checks_requested]
 
@@ -36,13 +36,14 @@ jobs:
         run: yarn build
 
       - name: Upload Build Results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: build-output
           path: |
             packages/@magic-ext/*/dist
             packages/@magic-sdk/*/dist
             packages/*/dist
+          overwrite: true
 
   create_canary:
     runs-on: ubuntu-20.04
@@ -68,7 +69,7 @@ jobs:
           yarn install --immutable
 
       - name: Download Build Results
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: build-output
           path: packages

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -2,7 +2,7 @@ name: Publish
 on:
   push:
     branches:
-      - "master"
+      - 'master'
 
 env:
   GITHUB_TOKEN: ${{ secrets.ARI_ADMIN_PAT_TOKEN }}
@@ -52,13 +52,14 @@ jobs:
         run: yarn build
 
       - name: Upload Build Results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: build-output
           path: |
             packages/@magic-ext/*/dist
             packages/@magic-sdk/*/dist
             packages/*/dist
+          overwrite: true
 
   publish:
     runs-on: ubuntu-20.04
@@ -88,7 +89,7 @@ jobs:
           yarn install --immutable
 
       - name: Download Build Results
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: build-output
           path: packages