Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 5 second interval "Heartbeat" to RpcProvider #17

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Mar 29, 2023

Android's Webview garbage collects memory intensive items like the iFrame when it's no longer being used. This prevents the OS from doing so and creating app hang ups.

@Ariflo Ariflo requested a review from Ethella March 29, 2023 05:10
@Ariflo Ariflo self-assigned this Mar 29, 2023
@shortcut-integration
Copy link

Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise LGTM

@Ariflo Ariflo changed the title Adds 2 min interval "Heartbeat" to RpcProvider Adds 5 second interval "Heartbeat" to RpcProvider Mar 30, 2023
@Ariflo Ariflo merged commit 7265843 into main Mar 30, 2023
@Ariflo Ariflo deleted the ariflo-sc-72401-adds-mgbox-ping branch March 30, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants