-
Notifications
You must be signed in to change notification settings - Fork 10
feat: realtime notification listener #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
smeijer
reviewed
Jul 10, 2025
packages/magicbell-js/package.json
Outdated
"/project-client/package.json", | ||
"/user-client/package.json" | ||
"/user-client/package.json", | ||
"/realtime/package.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A left over?
Suggested change
"/realtime/package.json", |
smeijer
reviewed
Jul 10, 2025
Comment on lines
1
to
4
{ | ||
"main": "../dist/commonjs/realtime.js", | ||
"types": "../dist/commonjs/realtime.d.ts" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be deleted, i guess
smeijer
approved these changes
Jul 10, 2025
Merged
moxley01
pushed a commit
that referenced
this pull request
Jul 10, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#553](#553) [`fc604f4`](fc604f4) Thanks [@moxley01](https://github.com/moxley01)! - add 'socket' client for realtime notification listening Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliberately kept this quite simple: does not try to maintain a cache or anything like that, it assumes that the consumer does this themselves. This is just providing a listener for new notifications as they come in, as an alternative to polling.
@smeijer I took some of your
in-app
methods and used them as-is (e.g.getUrl
,getToken
). Not sure whether you think we should try and deduplicate this or if its even worth it.If you think this approach is way off the mark, feel free to just close it.
Usage would be like:
Tested with
npm link
in a sample project and it works.