-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #100 from mageplaza/2.4-develop
Clean code
- Loading branch information
Showing
21 changed files
with
2,094 additions
and
2,094 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,41 @@ | ||
| <!--- | ||
| Thank you for contributing to Mageplaza extension. | ||
| To help us process this pull request we recommend that you add the following information: | ||
| - Summary of the pull request, | ||
| - Issue(s) related to the changes made, | ||
| - Manual testing scenarios | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| <!--- Please provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description (*) | ||
| <!--- | ||
| Please provide a description of the changes proposed in the pull request. | ||
| Letting us know what has changed and why it needed changing will help us validate this pull request. | ||
| --> | ||
|
|
||
| ### Related Pull Requests | ||
| <!-- related pull request placeholder --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- | ||
| If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>. | ||
| There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change. | ||
| --> | ||
| 1. Fixes mageplaza/magento-2-smtp#<issue_number> | ||
|
|
||
| ### Manual testing scenarios (*) | ||
| <!--- | ||
| Please provide a set of unambiguous steps to test the proposed code change. | ||
| Giving us manual testing scenarios will help with the processing and validation process. | ||
| --> | ||
| 1. ... | ||
| 2. ... | ||
|
|
||
| ### Questions or comments | ||
| <!--- | ||
| If relevant, here you can ask questions or provide comments on your pull request for the reviewer | ||
| For example if you need assistance with writing tests or would like some feedback on one of your development ideas | ||
| --> | ||
|
|
||
| <!--- | ||
| Thank you for contributing to Mageplaza extension. | ||
| To help us process this pull request we recommend that you add the following information: | ||
| - Summary of the pull request, | ||
| - Issue(s) related to the changes made, | ||
| - Manual testing scenarios | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| <!--- Please provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description (*) | ||
| <!--- | ||
| Please provide a description of the changes proposed in the pull request. | ||
| Letting us know what has changed and why it needed changing will help us validate this pull request. | ||
| --> | ||
|
|
||
| ### Related Pull Requests | ||
| <!-- related pull request placeholder --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- | ||
| If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>. | ||
| There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change. | ||
| --> | ||
| 1. Fixes mageplaza/magento-2-smtp#<issue_number> | ||
|
|
||
| ### Manual testing scenarios (*) | ||
| <!--- | ||
| Please provide a set of unambiguous steps to test the proposed code change. | ||
| Giving us manual testing scenarios will help with the processing and validation process. | ||
| --> | ||
| 1. ... | ||
| 2. ... | ||
|
|
||
| ### Questions or comments | ||
| <!--- | ||
| If relevant, here you can ask questions or provide comments on your pull request for the reviewer | ||
| For example if you need assistance with writing tests or would like some feedback on one of your development ideas | ||
| --> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,64 +1,64 @@ | ||
| <?php | ||
| /** | ||
| * Mageplaza | ||
| * | ||
| * NOTICE OF LICENSE | ||
| * | ||
| * This source file is subject to the Mageplaza.com license that is | ||
| * available through the world-wide-web at this URL: | ||
| * https://mageplaza.com/LICENSE.txt | ||
| * | ||
| * DISCLAIMER | ||
| * | ||
| * Do not edit or add to this file if you wish to upgrade this extension to newer | ||
| * version in the future. | ||
| * | ||
| * @category Mageplaza | ||
| * @package Mageplaza_Seo | ||
| * @copyright Copyright (c) Mageplaza (https://www.mageplaza.com/) | ||
| * @license http://mageplaza.com/LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Mageplaza\Seo\Block\Adminhtml\SeoChecker; | ||
|
|
||
| use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface; | ||
| use Mageplaza\Seo\Helper\Data; | ||
|
|
||
| /** | ||
| * Class CheckButton | ||
| * @package Mageplaza\Seo\Block\Adminhtml\SeoChecker | ||
| */ | ||
| class CheckButton implements ButtonProviderInterface | ||
| { | ||
| /** | ||
| * @var Data | ||
| */ | ||
| protected $helper; | ||
|
|
||
| /** | ||
| * CheckButton constructor. | ||
| * | ||
| * @param Data $helper | ||
| */ | ||
| public function __construct(Data $helper) | ||
| { | ||
| $this->helper = $helper; | ||
| } | ||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| public function getButtonData() | ||
| { | ||
| if (!$this->helper->isEnabled()) { | ||
| return []; | ||
| } | ||
|
|
||
| return [ | ||
| 'label' => __('Check On-page'), | ||
| 'class' => 'action-secondary save', | ||
| 'on_click' => 'jQuery("#mageplaza-seo-form").attr("action", "http://seo.mageplaza.com").submit();', | ||
| 'sort_order' => 85 | ||
| ]; | ||
| } | ||
| } | ||
| <?php | ||
| /** | ||
| * Mageplaza | ||
| * | ||
| * NOTICE OF LICENSE | ||
| * | ||
| * This source file is subject to the Mageplaza.com license that is | ||
| * available through the world-wide-web at this URL: | ||
| * https://mageplaza.com/LICENSE.txt | ||
| * | ||
| * DISCLAIMER | ||
| * | ||
| * Do not edit or add to this file if you wish to upgrade this extension to newer | ||
| * version in the future. | ||
| * | ||
| * @category Mageplaza | ||
| * @package Mageplaza_Seo | ||
| * @copyright Copyright (c) Mageplaza (https://www.mageplaza.com/) | ||
| * @license http://mageplaza.com/LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Mageplaza\Seo\Block\Adminhtml\SeoChecker; | ||
|
|
||
| use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface; | ||
| use Mageplaza\Seo\Helper\Data; | ||
|
|
||
| /** | ||
| * Class CheckButton | ||
| * @package Mageplaza\Seo\Block\Adminhtml\SeoChecker | ||
| */ | ||
| class CheckButton implements ButtonProviderInterface | ||
| { | ||
| /** | ||
| * @var Data | ||
| */ | ||
| protected $helper; | ||
|
|
||
| /** | ||
| * CheckButton constructor. | ||
| * | ||
| * @param Data $helper | ||
| */ | ||
| public function __construct(Data $helper) | ||
| { | ||
| $this->helper = $helper; | ||
| } | ||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| public function getButtonData() | ||
| { | ||
| if (!$this->helper->isEnabled()) { | ||
| return []; | ||
| } | ||
|
|
||
| return [ | ||
| 'label' => __('Check On-page'), | ||
| 'class' => 'action-secondary save', | ||
| 'on_click' => 'jQuery("#mageplaza-seo-form").attr("action", "http://seo.mageplaza.com").submit();', | ||
| 'sort_order' => 85 | ||
| ]; | ||
| } | ||
| } |
Oops, something went wrong.