Merged
Conversation
jcalcaben
added
pkg:peregrine
pkg:pwa-devdocs
documentation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-jimothy-gh-1346usepagination-hook-docs.magento-research1.now.sh |
Contributor
Author
|
on hold until #1381 is merged, then I will need to rebase these changes on top of the work done in that PR |
Contributor
|
Contributor
|
@jcalcaben we're good to go now -- the other PR was merged. |
jcalcaben
force-pushed
the
jimothy/gh-1346_usePagination-hook-docs
branch
from
759b869 to
e2b327e
Compare
sirugh
reviewed
Jul 29, 2019
sirugh
approved these changes
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add JSDoc blocks to the
usePagination.jssource and create a draft topic for the corresponding reference page.Related Issue
Closes #1346
Verification Steps
pwa-devdocsdirectorynpm run build-reference-doc-snippetsusePagination.mdfile was created insrc/_includes/auto-generated/peregrine/src/hooks/with doc block content from thepackages/peregrine/src/hooks/usePagination.jssource file.Screenshots / Screen Captures (if appropriate)
n/a
Checklist: