Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, show times in admin grids in the store timezone. #9941

Merged
merged 1 commit into from
Jun 16, 2017
Merged

By default, show times in admin grids in the store timezone. #9941

merged 1 commit into from
Jun 16, 2017

Commits on Jun 14, 2017

  1. By default, show times in admin grids in the store timezone. 

    fixes magento#9426

This test basically said, use the column config value, or use FALSE:

    $timezone = isset($this->getConfiguration()['timezone'])
        ? $this->booleanUtils->convert($this->getConfiguration()['timezone'])
        : false;

The only config values currently present in the code set the 'timezone'
config to FALSE using `<timezone>false</timezone>`. There are 0 occurances
of `<timezone>true</timezone>` in the code base at this time. This makes
me believe that the default value should not be FALSE but TRUE. Otherwise
the outcome will always be FALSE, be it explicit or by default.

This way the product review created_at times will be the same in the
catalog/product/edit adminhtml page as well as on the Marketing | Reviews
grid. They were not equal before this commit.

The same goes for the CMS page grid, the CMS block grid, the customer grid,
the online customers grid, and the sales grids.

I believe admins wint to see these times in their configured time zone and
not in UTC. Otherwise someone can appear to have placed an order in the
future which is very confusing.
    Anton Evers committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    049cc45 View commit details
    Browse the repository at this point in the history