Fixes Mage.Cookies poor performance #9835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing performance of Magento 1 and Magento 2 websites I was surprised by the time of Mage.Cookies.get calls execution being around 5-10 ms based on number of cookies stored.
This is how it looks on Land Rover website:
What I've found is that the Cookies class uses document.cookie property in extremely not effective way.
Document.cookie call is not just a string property retrieving -
Quote from w3c documentation on document.cookie
Single call can take from 0,03 to 10 milliseconds on various browsers/devices.
Simple test to reproduce in different browsers/devices : https://jsfiddle.net/rtxee657/1/.
Description
This pull request reduce the time for a Mage.Cookies.get call around 10 times without any side effects, and that gives average Magento 2 based website 1-2% faster page load.
Contribution checklist