Backport of MAGETWO-69152: Removed workaround for old Webkit bug in t… #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he TinyMCE editor for selections of images and hr elements, because this workaround now causes problems in Google Chrome version 58. (cherry picked from commit 4d10f05)
omiroshnichenko
approved these changes
May 18, 2017
magento-team
pushed a commit
that referenced
this pull request
May 19, 2017
magento-team
pushed a commit
that referenced
this pull request
May 19, 2017
[EngCom] Public Pull Requests - 2.1 - MAGETWO-69238: Keep transparency when resizing images [2.1 backport] #9662 - MAGETWO-69236: Add configurations for change email templates [2.1 backport] #9661 - MAGETWO-69235: Do not di:compile tests/ folder #9660 - MAGETWO-69223 Fix for #9646 #9647 - MAGETWO-69234: Backport of MAGETWO-69152: Removed workaround for old Webkit bug #9655
|
@hostep thank you for your contribution |
|
Thanks! @magento-team or @omiroshnichenko: can you please give some more info about backporting this to Magento 2.0.x and Magento 1.x Thanks! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he TinyMCE editor for selections of images and hr elements, because this workaround now causes problems in Google Chrome version 58.
(cherry picked from commit 4d10f05)
Description
This is a backport of issue MAGETWO-69152 for Magento 2.1
Fixed Issues (if relevant)
Reference to the commit on the develop branch:
4d10f05
Discussion
Be aware, this is a slightly different commit then the original one, because on the develop branch we have this commit which was applied: ead58ef, but it isn't applied on the 2.1-develop branch, so there were conflicts in the minified files, please review this again, because I didn't actually test it.
Also: I believe this bug is pretty important to be fixed in Magento 2.0.x as well, are you guys taking care of that?
Also: The same is true for Magento 1.x, can you guys try to communicate this to the M1 support people and try to get it included in the next release of Magento 1.x, and maybe even create a SUPEE-patch for this. Since not every Magento 1 shop will be running on the latest version. For example, we currently maintain around 60 Magento 1 shops which aren't on the very last version (ranging between 1.7.0.2 and 1.9.1.0)
Thanks!