Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Website id is incorrectly used for store filter when retrieving products on category page. Store id should be used instead.
Manual testing scenarios
Having the following store structure:


When i access a category page on store Store View 2, no products are displayed because of wrong filter.
Example: Go to http://local-magento2/storeview2/test-some-category-path.html
When debugging the category page, at
\Magento\Framework\Search\Adapter\Mysql\TemporaryStorage::storeDocumentsFromSelect
, the expression$select . ''
is evaluated to:This query returns empty result. Changing
visibility_filter.store_id = 4
tovisibility_filter.store_id = 5
, the query returns the expected products from category.Note that the Website 2 has id 4 and Store View 2 has id 5.
Contribution checklist