Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depends per group in system.xml #9391

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Fix depends per group in system.xml #9391

merged 1 commit into from
Jun 15, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Apr 25, 2017

Hide only inputs from fieldset (group) when depends it's leveled for group in system.xml

Description

When you have a <depends> in group the result is that all inputs and groups are hidded, including a depends field.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. create a module
  2. add system.xml
  3. create a group general with field enable yes/no
  4. create 2 groups test and test2
  5. inside group test add depends to general/enable -> 1
  6. go to admin and change value of general->enable

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Hide only inputs from fieldset (group) when depends it's leveled for group in system.xml
@osrecio osrecio changed the title Update form.js Fix depends per group in system.xml Apr 25, 2017
@okorshenko okorshenko self-assigned this May 16, 2017
@okorshenko okorshenko added this to the May 2017 milestone May 16, 2017
@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@vherasymenko
Copy link

@osrecio Hi. Could you please add more steps or add your .xml code for reproduce your bug.
I try reproduce issue using your steps and it nothing brings.

@osrecio
Copy link
Member Author

osrecio commented Jun 8, 2017

Hi @k7triton ,
I created a Sample Module to test: test-groupsm2 (You can add inside app/code)

Also I recorded my screen with effect:
Before
After

@magento-team magento-team merged commit 419d894 into magento:develop Jun 15, 2017
magento-team pushed a commit that referenced this pull request Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants