Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis sess: fix path for persistent_identifier & compression_threshold #9368

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

LukeHandle
Copy link
Contributor

@LukeHandle LukeHandle commented Apr 23, 2017

Currently, the paths for both persistent_identifier & compression_threshold are prefixed with param_. This is against both the documentation and it does not follow the standard used throughout the configuration. This PR removes the prefix.

Docs:
https://github.com/magento/devdocs/blob/develop/guides/v2.0/config-guide/redis/redis-session.md#configure-magento-to-use-redis-for-session-storage

Fixed Issues (if relevant)

Currently, persistent_identifier and compression_threshold are ignored in the Redis session configuration (the documented options for configuring).

Manual testing scenarios

Change compression_threshold to 1 (to force compression) and the sessions will not be compressed. Changing the name to be param_compression_threshold results in compression.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

The paths for both `persistent_identifier` & `compression_threshold` are prefixed with `param_`. This is against both the documentation and it does not follow the standard used throughout the configuration.

https://github.com/magento/devdocs/blob/develop/guides/v2.0/config-guide/redis/redis-session.md#configure-magento-to-use-redis-for-session-storage
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 23, 2017

CLA assistant check
All committers have signed the CLA.

@maghamed maghamed self-requested a review April 24, 2017 10:51
@maghamed maghamed self-assigned this Apr 24, 2017
@LukeHandle
Copy link
Contributor Author

Hey @maghamed, anything else needed from me here? I doubt that anyone is using the incorrectly named variants. Will also need back porting into 2.0.

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 2, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 2, 2017
@magento-team magento-team merged commit e386223 into magento:develop Jun 9, 2017
magento-team pushed a commit that referenced this pull request Jun 9, 2017
LukeHandle added a commit to LukeHandle/devdocs that referenced this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants