Add ability to inject exception code in LocalizedException #9363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add exception code
|
@adragus-inviqa Could you please update the test for the |
|
Will do. I'll need to remove the dust off my M2 unit testing skillz, though. Gimme some time. |
|
@adragus-inviqa Let me know if you need any assistance with this |
|
@adragus-inviqa I've added unit test, will proceed with the merge. |
|
Many thanks. |
magento-team
pushed a commit
that referenced
this pull request
May 9, 2017
…tion #9363 - Unit Test Added
magento-team
pushed a commit
that referenced
this pull request
May 9, 2017
magento-team
pushed a commit
that referenced
this pull request
May 9, 2017
[EngCom] Public Pull Requests - MAGETWO-68979: Fix breadcrumbs extra space #9514 - MAGETWO-68977: fix for Class Magento\Framework\Console\CLI not found in case sensitive scenarios #9539 - MAGETWO-68861: Fix data deletion using the multiple delete command #9446 - MAGETWO-67722: Add ability to inject exception code in LocalizedException #9363
|
@adragus-inviqa thank you for your contribution. Your Pull Request has been successfully merged |
magento-team
pushed a commit
that referenced
this pull request
Jun 29, 2017
…tion #9363 - Expanded initial implementation
magento-team
pushed a commit
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why you've chosen to always pass in
0. It's so much easier to work with codes.This change should be BC.