Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standard violations in the Framework\App namespace #9350

Merged
merged 2 commits into from
Apr 22, 2017
Merged

Fixed coding standard violations in the Framework\App namespace #9350

merged 2 commits into from
Apr 22, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 21, 2017

Fixed coding standard violations in the Framework\App namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed @codingStandardsIgnoreFile from the head of the file
  • Move ActionFake to it's own file, because PSR-2 dicates only one class per file.
  • Fixed indentation
  • Fixed number of chars per line

…hat it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

- Removed @codingStandardsIgnoreFile from the head of the file
- Move ActionFake to it's own file, because PSR-2 dicates only one class per file.
- Fixed indentation
- Fixed number of chars per line
- Reverted change is Mysql.php which should not have been in this commit / branch
@okorshenko okorshenko self-assigned this Apr 22, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 22, 2017
@magento-team magento-team merged commit df9e435 into magento:develop Apr 22, 2017
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution

@dverkade dverkade deleted the Fix_coding_standard_in_Framework-App branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants