Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace framework's Zend_Session interface usage with SessionHandlerInterface #9348

Merged
merged 1 commit into from
May 25, 2017

Conversation

tdgroot
Copy link
Member

@tdgroot tdgroot commented Apr 21, 2017

Replace framework's Zend_Session_SaveHandler_Interface usage with php's builtin SessionHandlerInterface.

Description

This seems to be the cleanest solution, the two interfaces declare exactly the same methods, so there shouldn't be any difference.

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Session #9242: Upgrade ZF components. Zend_Session

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@maghamed maghamed self-requested a review April 24, 2017 10:54
@maghamed maghamed self-assigned this Apr 24, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this May 20, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 20, 2017
@magento-team magento-team merged commit 1017e9d into magento:develop May 25, 2017
magento-team pushed a commit that referenced this pull request May 25, 2017
@magento-team
Copy link
Contributor

@tdgroot thank you for your contribution to Magento 2 project

@tdgroot tdgroot deleted the develop-replace_zend_session branch June 2, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants