Fixed coding standard violations in all Factory classes located in app/code #9304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de folder, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes: - Removed the @codingStandardsIgnoreFile from the head of the file. - Fixed line length - Changed is_null function to a === null compare. - Grouped the same constants together
dverkade
changed the title
- Reverted PaymentTokenInterfaceFactory, added ignoring coding standard, because renameing this will need to change a lot of files in different modules. I'll create a seperate PR for this change.
magento-team
pushed a commit
that referenced
this pull request
Apr 19, 2017
…s located in app/code #9304
|
@dverkade thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coding standard violation for all factory classes in the app/code folder, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes: