remove duplicate calls to initObjectManager in bootstrap class #9140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Bartlomiejsz
reviewed
Apr 6, 2017
| @@ -279,7 +279,6 @@ protected function assertMaintenance() | |||
| if (null === $isExpected) { | |||
| return; | |||
| } | |||
| $this->initObjectManager(); | |||
| /** @var \Magento\Framework\App\MaintenanceMode $maintenance */ | |||
| $this->maintenance = $this->objectManager->get(\Magento\Framework\App\MaintenanceMode::class); | |||
There was a problem hiding this comment.
I think this could also be removed :) Maintenance is now also initialized in constructor.
There was a problem hiding this comment.
@Bartlomiejsz i think we can remove Maintenance initialization from constructor .
I don't know why Maintenance initialization happens in two times (assertMaintenance method,initObjectManager method)
i think Its enough in assertMaintenance.
anyway I'm looking for core team feedback?
There was a problem hiding this comment.
@sivajik34 @Bartlomiejsz To me it looks like it is enough only once. Seems to be some artifacts from legacy code. Going to look into it more deeply.
|
@sivajik34 thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are duplicate calls for initobjectManager method,i think we can initialize objectmanager in constructor,so that object manager class will be available at the time of bootstrap object creation.