Fix to allow Zend_Db_Expr as column default #9131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if you attempt to use a
Zend_Db_Expr
as the default value for a column, it fails because it is accidentally converted to a string too early, which results in a malformed SQL query.This is due to a check that attempts to avoid double quoting but isn't careful to ensure the passed value is a string, triggering an implicit type conversion.
Manual testing scenarios
Create a column in a setup script similar to this:
Before this PR that fails with the exception:
After this PR the column is created correctly.