Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2461 #8959

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Fixes #2461 #8959

merged 1 commit into from
Mar 21, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Mar 21, 2017

Description

Fixed Issues (if relevant)

  1. magento/magetno2#2461: Max execution time of 60 seconds exceeded in CLI

Manual testing scenarios

  1. set php's max_execution_time to 0
  2. run bin/magento setup:static-content:deploy en_US nl_NL de_DE fr_FR en_UK
  3. time it to be longer than a minute and see that the error PHP Fatal error: Maximum execution time of 60 seconds exceeded does not appear
  4. make sure the command exits succesfully

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@AntonEvers
Copy link
Contributor Author

This pull request fixes #2461

@magento-team magento-team merged commit 7afeac0 into magento:develop Mar 21, 2017
magento-team pushed a commit that referenced this pull request Mar 21, 2017
magento-team pushed a commit that referenced this pull request Mar 21, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@ajpevers Thank you for the contribution!

@AntonEvers
Copy link
Contributor Author

@vrann glad to help!

@AntonEvers
Copy link
Contributor Author

@vrann I just received news from @tubalmartin:

Just to let you know guys, as the maintainer of YUI-CSS-compressor-PHP-port, that I've just released v3.0.0 which is the most stable release to date. Updating to this version is strongly recommended.

@AntonEvers AntonEvers deleted the issue-2461 branch April 13, 2017 09:11
@ishakhsuvarov
Copy link
Contributor

@ajpevers Any chance you would like to submit a PR with that? Or is it too much from the breaking changes perspective?

@AntonEvers
Copy link
Contributor Author

@ishakhsuvarov I'll check out the differences first. Keep you posted.

@AntonEvers
Copy link
Contributor Author

@ishakhsuvarov I've tested it and the upgrade is not yet compatible. I can't promise that I'll find the time any time soon to figure out why. So maybe I'll leave it for now. If any of you guys finds the time, supposedly there are performance improvements made in the css minifier. I don't know if they are so big that they make an actual difference in compilation time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants