Fixed Issue #8425 #8678
Merged
Fixed Issue #8425 #8678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of PHP_BINARY instead of 'php' should affect the used PHP Version. With the Constant, the correct php version should be called.
|
This might be used in another place, this fix should be good for any raw |
|
@vrann this is the PR we were talking about during MageTitansMX |
orlangur
approved these changes
Feb 25, 2017
vrann
approved these changes
Mar 1, 2017
|
@DavidLambauer PR has now been merged to the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of PHP_BINARY instead of 'php' should affect the used PHP Version. With the Constant, the correct php version should be called.