Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the copyright year from file headers #8648

Merged

Conversation

jameshalsall
Copy link

@jameshalsall jameshalsall commented Feb 22, 2017

This removes the license years from all file headers and instead adds it to the COPYING.txt file, which is referenced from the file headers themselves.

This will prevent mass changes to files each year, as we will only need to update the year in COPYING.txt.

@orlangur
Copy link
Contributor

It was planned to not ever change the header initially: #1234 (comment) :(

Dunno who came up with an idea to bump copyright year once again and then do it on regular basis. Somehow many other products don't have legal issues which require years to be specified in each single file.

@okorshenko okorshenko self-assigned this Mar 11, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 28, 2017
@okorshenko
Copy link
Contributor

@jameshalsall thank you for your contribution. We are working right now on merging this PR. This will take some time due to a huge changeset. We are doing our best to process this PR as soon as possible. Please, do not rebase/change this branch. We will resolve existing conflicts on our side.
Thank you

@magento-team magento-team merged commit a31f4a3 into magento:develop Mar 30, 2017
magento-team pushed a commit that referenced this pull request Mar 30, 2017
@okorshenko
Copy link
Contributor

@jameshalsall thank you for your contribution. Your pull request successfully merged to develop branch. 🎉

@orlangur Dreams Come True!

magento-team pushed a commit that referenced this pull request Mar 31, 2017
magento-team pushed a commit that referenced this pull request Mar 31, 2017
magento-team pushed a commit that referenced this pull request Mar 31, 2017
magento-team pushed a commit that referenced this pull request Mar 31, 2017
magento-team pushed a commit that referenced this pull request Mar 31, 2017
@orlangur
Copy link
Contributor

That's really impressive 👍 So, there will be separate micro-release with these changes or previous one could be reverted?

My best expectation was for it to be postponed till 2018 and then changed last time, I'm glad I was wrong :)

magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 1, 2023
…mance-optimizations

[LYNX] Performance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants