Set correct primary keys for temporary tables in product flat indexer #8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set 'row_id' as primary key because joins are made on it. Without this change product flat reindex can get practically stuck while making insert-from-select query in Magento\Catalog\Model\Indexer\Product\Flat\FlatTableBuilder::_fillTemporaryFlatTable.
|
|
|
Fixed this PR to be compatible with both CE and EE, although seems that CE is not affected by this issue. Field to be set as primary key is retrieved from the metadata, so for CE field will be entity_id and for EE row_id. |
Fix to be compatible with both CE and EE.
Fix too long line.
maghamed
approved these changes
Mar 1, 2017
|
@jarnooravainen Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set 'row_id' as primary key because joins are made on it. Without this change product flat reindex can get practically stuck while making insert-from-select query in Magento\Catalog\Model\Indexer\Product\Flat\FlatTableBuilder::_fillTemporaryFlatTable.