Convert MageBraintree to use the serializer rather than Zend_Json

[dmanners]

As Zend1 is end of life usage of Zend_Json should be converted to the internal serializer in Magento2

[ishakhsuvarov]

Currently we can not accept majority of the changes which modify the constructor signature.
This requirement is introduced to maintain maximum compatibility with already existing extensions and customizations, potentially relying on the class via extending.

[ishakhsuvarov]

@dmanners Currently we can not accept majority of the changes which modify the constructor signature.
This requirement is introduced to maintain maximum compatibility with already existing extensions and customizations, potentially relying on the class via extending.

To add a new parameter to the constructor you may introduce it as optional, for example:

public function __construct(
    \Magento\Framework\Serialize\SerializerInterface $serializer = null
) {
    $this->serializer = $serialize ?: \Magento\Framework\App\ObjectManager::getInstance()->get(\Magento\Framework\Serialize\SerializerInterface::class);
}

[dmanners]

Thanks for the feedback @ishakhsuvarov I guess that covers all the other zend_json PRs I have put in over the last few days.

[ishakhsuvarov]

@dmanners Thank you for the update. We are going to proceed with processing now.

[okorshenko]

@dmanners Thank you for your contribution to Magento 2 project! Your pull request has been successfully merged! For some reason, we have different your commit hashes that's why this PR is not closed. But your changes already on develop branch. Thank you

[dmanners]

@okorshenko thanks. It is probably cause I like to keep my branches up to date and regularly rebase them. You may have merged an older version or something. No issue there as there where no new commits added after the rebase.