Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zend1 Json from Magento Captcha module #8331

Merged
merged 9 commits into from
Feb 9, 2017
Merged

Remove Zend1 Json from Magento Captcha module #8331

merged 9 commits into from
Feb 9, 2017

Commits on Feb 7, 2017

  1. Replace usage of Zend_Json in Magento Captcha with the \Magento\Frame… 

    …work\Serialize\SerializerInterface
    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    d3fa692 View commit details
    Browse the repository at this point in the history

  2. Replace the usage of json_encode in app/code/Magento/Captcha/Controll… 

    …er/Refresh/Index.php to use the lib json serializer object
    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    5d68d6c View commit details
    Browse the repository at this point in the history

  3. Replace the usage of json_encode and object manager in app/code/Magen… 

    …to/Captcha/Controller/Adminhtml/Refresh/Refresh.php
    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    65c9eff View commit details
    Browse the repository at this point in the history

  4. Update the phpdocs in the Captcha admin controller to include the cap… 

    …tcha helper
    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    e80321a View commit details
    Browse the repository at this point in the history

  5. Update phpcods to include the serializer object

    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    debea18 View commit details
    Browse the repository at this point in the history

  6. Fix serializer type hint in the admin controller of mage captcha module

    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    a26f8da View commit details
    Browse the repository at this point in the history

  7. Make sure that the new dependancy on SerializerInterface is not required

    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    298d3c5 View commit details
    Browse the repository at this point in the history

  8. Make sure that the optional dependancies are last in the constructor

    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    6a2e353 View commit details
    Browse the repository at this point in the history

  9. Specifically ask for the Json Serializer object and not just relying … 

    …on the interface that could change
    @dmanners
    dmanners committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    c5bb856 View commit details
    Browse the repository at this point in the history