Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of parameters passed to LogicException in AbstractTemplate.php #8327

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

bery
Copy link

@bery bery commented Jan 30, 2017

Parameters are passed in an incorrect order and trigger a fatal error

Parameters are passed in an incorrect order
@vrann vrann self-requested a review January 30, 2017 20:24
@vrann vrann self-assigned this Jan 30, 2017
@vrann vrann added the bugfix label Jan 30, 2017
@vrann
Copy link
Contributor

vrann commented Jan 31, 2017

@bery thank you for contribution.
Can you please provide:

  1. steps to reproduce
  2. unit or integration test to expose the issue

@bery
Copy link
Author

bery commented Feb 1, 2017

I am unsure that I will have the time to provide unit tests.. Steps to reproduce:

  • Enable inline frontend translations
  • Set Magento to developer mode (condition for that in catch expression)
  • Place an order or create a new customer account (most likely any operation that triggers an email)

@vrann
Copy link
Contributor

vrann commented Feb 1, 2017

@bery thank you, this helps. Will verify the flow and add tests as needed.

@mmansoor-magento mmansoor-magento merged commit d695b92 into magento:develop Feb 3, 2017
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- covered additional numeric cases with the communication.xsd schema changes
- added integration tests
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- add unit test for AbstractTemplate Exception
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- disable static test check for long line in unit tests
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- fix static test check for long line in unit tests
@okorshenko
Copy link
Contributor

Thank you for contribution to Magento 2 project!

magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants