Remove "<2.7" constraint on symfony/console #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This has been preventing PhpSpec 3 being used with Magento 2, and means Magento 2 cannot be used with any currently supported Symfony components |
okorshenko
suggested changes
Feb 3, 2017
| @@ -43,7 +43,7 @@ | |||
| "tubalmartin/cssmin": "2.4.8-p4", | |||
| "magento/magento-composer-installer": ">=0.1.11", | |||
| "braintree/braintree_php": "3.7.0", | |||
| "symfony/console": "~2.3 <2.7", | |||
There was a problem hiding this comment.
In order to avoid issue with depreciation exceptions from Symfony code I'd recommend change this dependency in the following way:
"symfony/console": "~2.3, !=2.7.0",
This issue was introduced in 2.7.0 and was fixed in 2.7.1
bug #14900 Silence deprecation warnings by default (reecefowell)
So we would like to avoid using of problematic version
Thank you for your efforts!
okorshenko
pushed a commit
to magento-engcom/composer
that referenced
this pull request
Feb 7, 2017
…: Remove "<2.7" constraint on symfony/console
okorshenko
pushed a commit
to magento-engcom/composer
that referenced
this pull request
Feb 7, 2017
…: Remove "<2.7" constraint on symfony/console - updated minor version of magento/composer due to new dependency on symfony/console
|
@nicolas-grekas your pull request successfully merged to develop branch. Thank you for your contribution! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 14, 2023
Arrows Team - Bugfix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to magento/composer#3: