Check return value for getProduct() in getPrice(). #7794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If getProduct() returns a NULL value then this code will generate a PHP warning and potentially crash the page; let's not do that, and check our return values before we try to call methods on them.
antonkril
suggested changes
Jan 10, 2017
Save results of methods called and clean up code in response to feedback and tests.
antonkril
approved these changes
Jan 10, 2017
| return $product->getCustomOption('simple_product')->getProduct()->getPrice(); | ||
| } else { | ||
| return 0; | ||
| if ( !empty( $product ) ) { |
There was a problem hiding this comment.
This check is not required
|
@pbaylies Thank you for contribution. Can you please fix following code styles issues: |
|
@vrann I can't reproduce this; I don't see any extra spaces at the end of those lines on my committed file. |
|
these lines should look like this: |
Coding style updates.
|
@vrann Done, thanks! |
|
@pbaylies Thank you! |
|
@pbaylies merged! |
hostep
pushed a commit
to hostep/magento2
that referenced
this pull request
Sep 2, 2017
…value for getProduct() in getPrice(). magento#7794 - Merge Pull Request magento#7794 from pbaylies/magento2:patch-2 (cherry picked from commit 6752968)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If getProduct() returns a NULL value then this code will generate a PHP warning and potentially crash the page; let's not do that, and check our return values before we try to call methods on them.