Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows you to have 0 as a option #7701

Merged
merged 2 commits into from
Mar 16, 2017
Merged

Allows you to have 0 as a option #7701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2c66b6
Allows you to have 0 as a option
Corefix Dec 6, 2016
c5cddd9
Update EavAttribute.php
Corefix Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Swatches/Model/Plugin/EavAttribute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ protected function isOptionsValid(array $options, Attribute $attribute)
if ($this->isOptionForDelete($attribute, $optionId)) {
continue;
}
if (empty($option[0])) {
if (!isset($option[0]) || $option[0] === '') {
return false;
}
}
Expand Down