Removed default values for title, meta description, better labels. #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paales
commented
Oct 1, 2016
•
paales
commented
- default_description + default_keywords are removed because they do more harm than good.
- default_title is not removed, since that field is a requirement to be set, better have a wrong value than no value at all
- Better label for Title: Page Title (Title is ambiguous, could als imply the first h1)
- Better label for description+keywords
- default_description + default_keywords are removed because they do more harm than good. - default_title is not removed, since that field is a requirement to be set, better have a wrong value than no value at all - Better label for Title: Page Title (Title is ambiguous, could als imply the first h1) - Better label for description+keywords
Igloczek
approved these changes
Feb 13, 2017
|
@paales thank you, merged! |
paales
added
the
Partner: Reach Digital
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.