Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addCategoriesFilter to return $this #6677

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Update addCategoriesFilter to return $this #6677

merged 1 commit into from
Mar 21, 2017

Conversation

maciekpaprocki
Copy link
Contributor

@maciekpaprocki maciekpaprocki commented Sep 20, 2016 •
edited by vrann
Loading

To keep consistency addCategoriesFilter should return $this. All Other methods seems to use fluent API.

@maciekpaprocki
Update addCategoriesFilter to return $this
23f2d5c 
To keep consistency addCategoriesFilter should return $this. All Other methods seems to use fluent API.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 20, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vrann vrann self-assigned this Mar 20, 2017
@vrann vrann added this to the March 2017 milestone Mar 20, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@maciekpaprocki Thank you for contribution, it is accepted.

@magento-team magento-team merged commit 23f2d5c into magento:develop Mar 21, 2017
magento-team pushed a commit that referenced this pull request Mar 21, 2017
@vrann
MAGETWO-66360: Update addCategoriesFilter to return $this #6677
ea828d1
@maciekpaprocki maciekpaprocki deleted the patch-1 branch March 21, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrann vrann

Labels
Component: Catalog Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@maciekpaprocki @magento-cicd2 @vrann @magento-team @vasiliyseleznev