Always skip hidden files #6567
Merged
Always skip hidden files #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, I just added my other email and accepted the license agreement - again... |
vrann
suggested changes
Mar 24, 2017
| @@ -87,6 +87,10 @@ public function getList($path) | |||
| */ | |||
| private function isExclude(\SplFileInfo $fileItem, $patterns) | |||
| { | |||
| if($fileItem->getBasename()[0] == '.') { | |||
There was a problem hiding this comment.
If you add this check here, it will be invoked for every pattern, while it need to be invoked just once per file. The better place for this piece will be here as a third skipped case
if ($fileItem->isDir() || $fileItem->getExtension() !== 'php') {
continue;
}
There was a problem hiding this comment.
Thanks for reviewing. I've updated the patch per your request.
magento-team
pushed a commit
that referenced
this pull request
Mar 25, 2017
magento-team
pushed a commit
that referenced
this pull request
Mar 25, 2017
|
@quickshiftin Merged! Thank you for your support. |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux with Emacs or VI, hidden files can be generated by the editor, which are then picked up by the ClassScanner, so periodically I run into errors like this when running
bin/magento di:compileYou may prefer to implement it as another
excludePattern, however I think it's worth adding in some fashion.