Change value-assignment to a setValue call #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there any reasons not to use Prototype's setValue call instead of assignment? Plain assignment breaks in case of a multiselect element. In case of multiselect, and an array in rowData.column_values[rowInputElementNames[i]] the first element of that array will be taken and assigned as the only selected value on a multiselect, which is clearly a broken behaviour. Prototype's setValue call will handle this case properly without breaking compatibility.
|
@wexo Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below. |
|
Hey, |
|
@wexo-dk could you please make sure that your commit signed with the same email as you have on GitHub. This will allow you to sign CLA. |
|
@okorshenko thanks for the notice. |
|
@wexo-dk thank you for your contribution |
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 20, 2019
[TSG-Commerce] Tests for 2.4 (pr1) (2.4-develop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reason not to use Prototype's setValue call instead of assignment?
Plain assignment breaks in case of a multiselect element.
In case of multiselect, and an array in
rowData.column_values[rowInputElementNames[i]]
the first element of that array will be taken and assigned as the only selected value on a multiselect, which is clearly a broken behaviour.
Prototype's setValue call will handle this case properly without breaking compatibility.