Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Search Engine Optimization i18n #502

Closed
wants to merge 1 commit into from

Conversation

Danw33
Copy link

@Danw33 Danw33 commented Feb 11, 2014

Modified Magento Core and Install Internationalization (i18n) to change "Search Engines Optimization" to "Search Engine Optimization" by removing the "s" from "Eninge" in all i18n CSV files and relevant configurations.

Tested against Magento 2.0.0.0-Dev64 (271615a) on Ubuntu - Changes are reflected as expected without errors or warnings (Developer Mode Enabled).

A quick Google search for "SEO" can confirm that (as my colleagues and I thought) SEO it is most commonly spelt (and spoken) as "Search Engine Optimization".

Corrected the i18n for Magento Core and Install to change "Search
Engines Optimization" to "Search Engine Optimization" (Removed the "s"
from "Eninge").
@tanya-soroka
Copy link

Hello @Danw33 ,
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.
Looking forward for new issues from you!

magento-team added a commit that referenced this pull request Mar 28, 2014
* Fixed bugs:
  * Fixed an issue with displaying product on the frontend when the product flat indexer is enabled
  * Fixed an issue with applying catalog price rules on the category level
  * Fixed an issue where the essential cookies like CUSTOMER, CART, and so on were not created in Google Chrome
  * Fixed an issue with placing orders by customers assigned to a VAT group
  * Fixed an issue with incorrect error message during registration, and inability for a shopper to ask for resending a confirmation email
  * Fixed an issue where the Catalog module resource Setup Upgrade logic was broken
* Modularity improvements:
  * Moved abstract Core models and related logic to the Magento/Model library
  * Moved the abstract DB logic and Core resource helpers to the Magento/DB library
  * Eliminated the Core\Model\App class
  * Moved the Magento Flag functionality to the library
  * Resolved dependency of the Catalog and related modules on the Review module
  * Moved indexers related logic from the Core module to the Indexer module
  * Moved the Inline translation and user intended translate functionality from the Core module to a separate Translation module
* Framework Improvements:
  * Covered Magento library components with unit tests:
     * Magento\Config
     * Magento\Convert
     * Magento\Controller
     * Magento\Data\Collection\Db
     * Magento\Mview
     * Magento\Url and Magento/Url.php
  * Covered Magento application components with unit tests:
     * Magento\Checkout\Model\Config
     * Magento\Checkout\Model\Observer
     * Magento\Checkout\Model\Type
     * Magento\Sales\Model\Config
  * Renamed LauncherInterface to AppInterface
* Improvements in code coverage calculation:
  * Updated the whitelist filter with library code for integration tests code coverage calculation
* GitHub requests:
  * [#512] (#512) -- Theme Thumbnails not showing
  * [#520] (#502) -- Corrected Search Engine Optimization i18n
  * [#519] (#519) -- New Theme Activation
* Customer Service usage:
  * Refactored the Log module to use Customer Service
  * Refactored the RSS module to use Customer Service
  * Refactored the Review module to use Customer Service
  * Refactored the Catalog module to use Customer service layer
  * Refactored the Downloadable module to use Customer service layer
@verklov
Copy link
Contributor

verklov commented Mar 28, 2014

@Danw33, the team has processed your pull request. The code has been released in version dev71. Thank you for your contribution!

@verklov verklov closed this Mar 28, 2014
magento-team pushed a commit that referenced this pull request Aug 4, 2015
magento-team pushed a commit that referenced this pull request Apr 1, 2016
[Tango] Stabilize functional tests for configurable product and product attributes
okorshenko pushed a commit that referenced this pull request Dec 14, 2016
[PERFORMANCE] Bugfixes 2.1
- MAGETWO-59138 Eliminate Slow Query for Media Gallery data
- MAGETWO-59397 [Cloud] Custom theme does not use parent xml configuration on multi thread deployment
- MAGETWO-59309 Static Assets deployment throws errors when redis is used for cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants