Fix #4430 (wrong exception raising during URL Rewrites saving process). #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I close this one since we have a better PR to propose to fix the #4430 issue. |
|
Do you have reference to new PR to fix issue 4430? |
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 8, 2019
[arcticfoxes] MC-19649: Granular ACL for B2B modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the #4430 issue.
The problematic double exception raising is deleted since it should be manage by the
::doReplacemethod as mentioned in its PHPDoc and as implemented into theMagento\UrlRewrite\Model\Storage\DbStorageclass.The exception handling in
::doReplaceprovides enough guarantees to avoid duplicate url keys.I suspect some kind of bug into the PHP engine (tested with PHP 7.0.6) since the original code seems valid to me but I was not able to figure what was wrong.