Set return code for SetModeCommand

[marvincaspar]

In case of running the bin/magento deploy:mode:set production command
in a shell script this will return an error code 129 and all other
commands after this will not be executed.

[vkorotun]

Internal ticket: MAGETWO-58373

[guz-anton]

Hi Marvin,
Could you provide an example (or describe an environment) when command deploy:mode:set fails?
It is interesting how you caught a situation with "other commands after this will not be executed".

-- Anton Guz

[marvincaspar]

Hi @guz-anton,
this happens if you want to setup magento on different environments with a shell script.

The script includes different steps:

• clone the repository
• import a backup
• set deployment mode
• clear cache
• run indexer
• do some other stuff

And if the command returns the wrong status code the script stops and the appended task will not execute.

[guz-anton]

Hmm.. I understand what is a shell script (or no?). For example:

#!/bin/bash

sudo -H -u www-data php bin/magento deploy:mode:set production
sudo -H -u www-data php bin/magento deploy:mode:set developer
sudo -H -u www-data php bin/magento deploy:mode:set default

touch sample.test.file
pwd
pwd
ls -la

I have successful directory listing in both cases: with your changes and without. So I want to understand when exactly you faced with issue. Could you list your .sh example?

[marvincaspar]

you have to use set -e to exit on the first error, for example:

#!/bin/bash

set -e

php bin/magento deploy:mode:set production

[guz-anton]

@mc388 great thanks for contribution!

[Ctucker9233]

@mmansoorebay @guz-anton is this PR going to be included in 2.1.3?