Update NL zipcode pattern. #4535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix message, and message to i18n
-fix some other cases of this bug
- add test for check empty file
…resented on checkout flow
…ache and static files - updated recursive creation of a directory to take into account race conditions
…ache and static files - Added integration test
…ache and static files - Remove redundant code
- updated CHANGELOG.md
…P / REST - fixed code style - fixed batching - removed unused variables and methods
…P / REST - fixed type of input parameters for iterator constructor
Magneto 2.0.1 Bug Fixes (Combined)
…P / REST - fixed iterator
…-sparta/magento2ce into MDVA-237
[SUPPORT] MDVA-198: 2.0.5 backlog
MAGETWO-51462: Magento 2.0.5 Publication
The NL zipcode is too strict. Magento 2 advises `1234 AB`, while it's very common to enter it like `1234AB`. That's why I made the space character optional.
|
Hi @Desmaster can you check your pull request one more time? probably you need to update your local repository. |
|
@vkorotun Yes I kind of messed up my fork, I'll clean it up soon soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NL zipcode is too strict.
Magento 2 advises
1234 AB, while it's very common to enter it like1234AB.That's why I made the space character optional.
My branch was based on 2.0.5 tag, hope that's not a problem for the pull request to be merged.