Static deploy flags #4294

denisristic · 2016-04-25T14:50:14Z

When calling setup:static-content:deploy now you are able to put flags to skip specific content and you are able to do that for specific theme(s)

Usage:
setup:static-content:deploy [-d|--dry-run] [--no-javascript] [--no-css] [--no-less] [--no-images] [--no-fonts] [--no-html] [--no-misc] [--no-html-minify] [-t|--theme[="..."]] [-et|--exclude-theme[="..."]] [-l|--language[="..."]] [-el|--exclude-language[="..."]] [-a|--area[="..."]] [-ea|--exclude-area[="..."]] [languages1] ... [languagesN]

Options:
--dry-run (-d) If specified, then no files will be actually deployed.
--no-javascript If specified, no JavaScript will be deployed.
--no-css If specified, no CSS will be deployed.
--no-less If specified, no LESS will be deployed.
--no-images If specified, no images will be deployed.
--no-fonts If specified, no font files will be deployed.
--no-html If specified, no html files will be deployed.
--no-misc If specified, no miscellaneous files will be deployed.
--no-html-minify If specified, just html will not be minified and actually deployed.
--theme (-t) If specified, just specific themes will be deployed (multiple values allowed)
--exclude-theme (-et) If specified, specific theme will not be deployed (multiple values allowed)
--language (-l) If specified, just specific language will be deployed (multiple values allowed)
--exclude-language (-el) If specified, specific language will not be deployed (multiple values allowed)
--area (-a) If specified, just specific area will be deployed (multiple values allowed)
--exclude-area (-ea) If specified, specific area will not be deployed (multiple values allowed)

…, images, fonts...) and filter by theme

…s (js, css, less, images, fonts...) and filter by theme"" This reverts commit 04ebbe796c2a11608581fecdf4d9b6645e19d2e1.

…filetypes (js, css, less, images, fonts...) and filter by theme""" This reverts commit 8216e12.

…ss, less, images, fonts...) and filter by theme" This reverts commit 4e65486.

…, images, fonts...) and filter by theme - fixed

adragus-inviqa · 2016-04-25T14:55:11Z

app/code/Magento/Deploy/Model/Deployer.php

+                return true;
+            } else  if ($this->isFonts && in_array($ext, array('eot', 'svg', 'ttf', 'woff', 'woff2'))) {
+                return true;
+            } else  if ($this->isMisc && in_array($ext, array('md', 'txt', 'jbf', 'csv', 'json', 'txt', 'htc', 'swf', 'LICENSE', ''))) {


Please use elseif instead of else if, or else if "so that all control keywords look like single words".

I would rather you put those file extension strings somewhere - if not configurable - at least more visible, like some private properties.

Done, thanks for your remarks

adragus-inviqa · 2016-04-25T14:57:22Z

Please use PHP 5.4's array notation - [] - instead of array. It's less noisy that way.

mazhalai · 2016-05-09T17:37:27Z

@denisristic thank you for your contribution, we have created MAGETWO-52614 to process this PR.

piotrekkaminski · 2016-05-23T05:43:51Z

@denisristic can you sign the contributor license agreement? it is stopping us from merging this nice improvement.

denisristic · 2016-05-23T18:48:53Z

@piotrekkaminski I've signed it several times but back then it didn't change status. As I can see now it's changed even though I haven't done anything

hostep · 2016-05-31T06:47:43Z

@denisristic: I happen to notice you changed the file permissions of the two php files from 644 to 755, I think you'll need to put them back to 644.

Other than that, @ Magento team: do you think this PR will be included in Magento version 2.1?
I haven't tested it yet, but it looks like the --themes switch will allow us to significantly improve the time for each deployment on a production server.

hostep · 2016-05-31T07:21:22Z

Just did some testing using this patch, in case anyone is interested (I'm running in production mode btw):

# First remove all caches
$ rm -R pub/static/*
$ rm -R var/cache/*
$ rm -R var/page_cache/*
$ rm -R var/generation/*
$ rm -R var/view_preprocessed/*

# Now run static deploy without a filter
$ time php bin/magento setup:static-content:deploy

...

New version of deployed files: 1464678133

real    6m35.824s
user    6m24.147s
sys     0m14.243s


# Now do the same, first removing all caches again
$ rm -R ...

# Run static deploy with filter on backend theme and our custom theme
$ time php bin/magento setup:static-content:deploy --themes Magento/backend --themes Vendor/custom

...

New version of deployed files: 1464678974

real    2m32.092s
user    2m23.732s
sys     0m5.688s

Over 2 times faster, wow!

Disclaimer: I have 2 custom themes set up, so the first run should be faster if you only have 1 custom theme.

Thanks @denisristic, awesome work!

Hope this gets merged in Magento 2.1 codebase.

erikhansen · 2016-06-01T14:32:25Z

@denisristic Thanks for working on this PR. Two suggestions/requests:

You may want to rename your --themes flag to --theme since it looks like you have to pass separate arguments for each theme you want to include. Alternatively you could rework your --themes flag to accept a comma-delimited list of themes. For example: bin/magento setup:static-content:deploy --themes=vendor/theme1,vendor/theme2
Per my comment on a issue Skip Luma theme when compiling static resources #3038, it would be great if you could add an --exclude-theme flag that would allow a developer to specify which themes NOT to include. This would be especially useful for a Magento site where new themes might be added over time and the merchant is using deployment scripts that have hard-coded deployment steps. For example: bin/magento setup:static-content:deploy --exclude-theme=magento/luma --exclude-theme=magento/blank

erikhansen · 2016-06-07T20:26:22Z

@denisristic Are you interested in adding a --exclude-theme flag as I suggested in my previous comment? If not, let me know.

@piotrekkaminski Can you confirm that you're intending to merge this PR once the current merge conflicts are resolved and it goes through code review?

denisristic · 2016-06-07T20:35:25Z

@erikhansen Thanks for your comments. I`ll add exclude flag version for themes until the end of the week.

piotrekkaminski · 2016-06-08T23:02:33Z

@erikhansen yes - it is very high in the backlog for next version (2.2), however won't be possible for 2.1.

giacmir · 2016-06-14T15:11:00Z

It would be nice to have a switch to automatically grab all configured languages without need to explicitly pass them as arguments. In case of installations with several languages it is pretty easy to forget one, and it is very useful for automated deploys.

erikhansen · 2016-06-20T19:40:29Z

@denisristic Any update on adding the --exclude-theme flag and resolving the merge conflicts in this branch so that this PR can be merged in?

@erikhansen

ADDDED --exclude-theme flag (@erikhansen suggestion) UPDATED --language flag (@giacmir) ADDED flags: --area (-a), --exclude-area (-ea), --exclude-language (-el), --exclude-theme (-et) ADDED flag shotcuts: -l, -el, -t, -et, -a, -ea ADDED check for wrong language, theme and/or area parameter value FIXED variable names, changet do camelCase

FIXED Invalid argument supplied for foreach() FIXED code style (PHPCS & PHPMD)

mslabko · 2016-06-30T12:03:52Z

Hi @denisristic
Could you please sign the License Agreement? https://cla.dev.magento.com/magento/magento2?pullRequest=4294

denisristic · 2016-07-05T19:35:55Z

Hi @mslabko ,
I've done it at least 20 times but it didn't change.
I can see that it is signed now even though I didn't do anything in last 10 days

mslabko · 2016-07-11T12:20:30Z

@denisristic ,
Thank you! Your PR already in progress.

sshrewz · 2016-08-11T22:26:58Z

@denisristic, we need you to sign the CLA before we can proceed with further actions your contribution.

adragus-inviqa · 2016-08-12T08:05:02Z

@denisristic, we need you to sign the CLA before we can proceed with further actions your contribution.

Not only did @denisristic say that he signed the thing 10 times, but I'm seeing it signed already. Fix the signing process already.

denisristic · 2016-08-12T08:14:24Z

@Snohe I've signed it at least 20x, there is some bug with signing process. As I can see now it is signed even though I didn't do anything

mslabko · 2016-08-12T11:58:13Z

@Snohe PR already in progress, CLA is applied.

mslabko · 2016-08-17T11:05:02Z

@denisristic , PR was merged to mainline. Thank you for the contribution!

Denis Ristic added 5 commits April 25, 2016 16:08

Added flags to static deploy command to skip filetypes (js, css, less…

4e65486

…, images, fonts...) and filter by theme

Revert "Revert "Added flags to static deploy command to skip filetype…

8216e12

…s (js, css, less, images, fonts...) and filter by theme"" This reverts commit 04ebbe796c2a11608581fecdf4d9b6645e19d2e1.

Revert "Revert "Revert "Added flags to static deploy command to skip …

478cc3e

…filetypes (js, css, less, images, fonts...) and filter by theme""" This reverts commit 8216e12.

Revert "Added flags to static deploy command to skip filetypes (js, c…

fc77f20

…ss, less, images, fonts...) and filter by theme" This reverts commit 4e65486.

Added flags to static deploy command to skip filetypes (js, css, less…

c1a09cd

…, images, fonts...) and filter by theme - fixed

adragus-inviqa reviewed Apr 25, 2016
View reviewed changes

Fixed code style, remarks by @adragus-inviqa

1cb1c2d

MomotenkoNatalia added the PS label Apr 25, 2016

Fixed method parameter instatiation when paramter is empty

6b66db7

okorshenko assigned mazhalai May 5, 2016

mazhalai added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 9, 2016

piotrekkaminski assigned choukalos and unassigned mazhalai May 23, 2016

piotrekkaminski added the Progress: accept label May 23, 2016

hostep mentioned this pull request Jun 1, 2016

Skip Luma theme when compiling static resources #3038

Closed

erikhansen mentioned this pull request Jun 20, 2016

Add flag to silence dot output from setup:static-content:deploy #3692

Closed

FIXED Avoid unused local variables such as '$languagedInclude'.

6766de7

FIXED Invalid argument supplied for foreach() FIXED code style (PHPCS & PHPMD)

mslabko self-assigned this Jun 30, 2016

mslabko added the in progress label Jun 30, 2016

vkorotun removed the PS label Aug 3, 2016

vasiliyseleznev added the Area: Frontend label Aug 3, 2016

vkorotun removed the Progress: accept label Aug 4, 2016

vkorotun unassigned choukalos and mslabko Aug 4, 2016

hostep mentioned this pull request Aug 5, 2016

Magento 2 Static Deploy Issue #4229

Closed

vkorotun added improvement and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 5, 2016

sshrewz added the linked label Aug 11, 2016

sshrewz added Progress: needs update and removed in progress labels Aug 11, 2016

mslabko removed the Progress: needs update label Aug 12, 2016

mslabko added the in progress label Aug 12, 2016

hostep mentioned this pull request Aug 13, 2016

Deployment and Front End Development #6131

Closed

mmansoor-magento merged commit 6766de7 into magento:develop Aug 17, 2016

vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016

erikhansen mentioned this pull request Aug 31, 2016

Add Github link for "improved the deployment of static assets" to 2.1.1 release notes magento/devdocs#804

Closed

hostep mentioned this pull request Jan 16, 2017

The "--theme" option does not exist. magento/devdocs#994

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Static deploy flags #4294

Static deploy flags #4294

denisristic commented Apr 25, 2016 •

edited

Loading

adragus-inviqa Apr 25, 2016

adragus-inviqa Apr 25, 2016 •

edited

Loading

denisristic Apr 25, 2016

adragus-inviqa commented Apr 25, 2016

mazhalai commented May 9, 2016

piotrekkaminski commented May 23, 2016

denisristic commented May 23, 2016

hostep commented May 31, 2016

hostep commented May 31, 2016

erikhansen commented Jun 1, 2016 •

edited

Loading

erikhansen commented Jun 7, 2016

denisristic commented Jun 7, 2016

piotrekkaminski commented Jun 8, 2016

giacmir commented Jun 14, 2016

erikhansen commented Jun 20, 2016

mslabko commented Jun 30, 2016

denisristic commented Jul 5, 2016 •

edited

Loading

mslabko commented Jul 11, 2016

sshrewz commented Aug 11, 2016

adragus-inviqa commented Aug 12, 2016

denisristic commented Aug 12, 2016

mslabko commented Aug 12, 2016

mslabko commented Aug 17, 2016

Static deploy flags #4294

Static deploy flags #4294

Conversation

denisristic commented Apr 25, 2016 • edited Loading

adragus-inviqa Apr 25, 2016

Choose a reason for hiding this comment

adragus-inviqa Apr 25, 2016 • edited Loading

Choose a reason for hiding this comment

denisristic Apr 25, 2016

Choose a reason for hiding this comment

adragus-inviqa commented Apr 25, 2016

mazhalai commented May 9, 2016

piotrekkaminski commented May 23, 2016

denisristic commented May 23, 2016

hostep commented May 31, 2016

hostep commented May 31, 2016

erikhansen commented Jun 1, 2016 • edited Loading

erikhansen commented Jun 7, 2016

denisristic commented Jun 7, 2016

piotrekkaminski commented Jun 8, 2016

giacmir commented Jun 14, 2016

erikhansen commented Jun 20, 2016

mslabko commented Jun 30, 2016

denisristic commented Jul 5, 2016 • edited Loading

mslabko commented Jul 11, 2016

sshrewz commented Aug 11, 2016

adragus-inviqa commented Aug 12, 2016

denisristic commented Aug 12, 2016

mslabko commented Aug 12, 2016

mslabko commented Aug 17, 2016

denisristic commented Apr 25, 2016 •

edited

Loading

adragus-inviqa Apr 25, 2016 •

edited

Loading

erikhansen commented Jun 1, 2016 •

edited

Loading

denisristic commented Jul 5, 2016 •

edited

Loading