Ensure composer.json exists #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw issue #3400 where there is a much wider discussion going on, but this is still annoying :) |
|
@DanK00 can you please resync with develop and restart builds? |
Before json encoding suggests. The current implementation forces all modules to have a composer.json file or they cannot install sample data.
|
@mazhalai done :) |
|
Internal ticket - MAGETWO-56786 |
vkorotun
added
Issue: Ready for Work
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 11, 2016
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 11, 2016
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 11, 2016
Fixed issues: - MAGETWO-60647: Delivery of bug fixes for Sample Data and Import/Export - MAGETWO-56787: [GITHUB][PR] Added call to action to compile command error #4134 - MAGETWO-56786: [GITHUB][PR] Ensure composer.json exists #4121 - MAGETWO-57799: cannot upgrade 2.0 => 2.1 with auto_increment > 1 - MAGETWO-59715: Impossible to import additional_images with labels which have a comma separator - MAGETWO-60633: [Github] .htaccess deny code execution not working for Apache + php-fpm #6766 - MAGETWO-46636: Nginx doesn't redirect to setup page when using port
|
Merged. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 26, 2019
[TSG] MTF fixes for 2.3 (pr15) (2.3.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure composer.json exists before json encoding suggests. The current implementation forces all modules to have a composer.json file or they cannot install sample data.
I discovered this issue when I tried to install sample data after creating my own hello world module.