Skip to content

fixing setup:di:compile area order in plugin generation so frontend a…#40408

Open
jakwinkler wants to merge 13 commits intomagento:2.4-developfrom
qoliber:di_compile_area_order_fix
Open

fixing setup:di:compile area order in plugin generation so frontend a…#40408
jakwinkler wants to merge 13 commits intomagento:2.4-developfrom
qoliber:di_compile_area_order_fix

Conversation

@jakwinkler
Copy link
Copy Markdown
Contributor

@jakwinkler jakwinkler commented Jan 7, 2026

This PR fixes this bug:
#40407

@jakwinkler
fixing setup:di:compile area order in plugin generation so frontend a…
5905ab4 
…rea cache picks up compiled files instead of regenerating on the first request
@m2-assistant
Copy link
Copy Markdown

m2-assistant bot commented Jan 7, 2026

Hi @jakwinkler. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link
Copy Markdown

ct-prd-pr-scan bot commented Jan 7, 2026

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Jan 7, 2026

@magento run all tests

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Jan 7, 2026

@magento run all tests

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Jan 8, 2026

@magento run all tests

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Jan 10, 2026

@magento run all tests
and do it fast ;-)

@rhoerr rhoerr mentioned this pull request Jan 11, 2026
Merged
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 13, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jan 13, 2026
@hostep hostep mentioned this pull request Feb 4, 2026
Closed
5 tasks
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Mar 5, 2026
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 5, 2026
@engcom-Hotel
Copy link
Copy Markdown
Contributor

engcom-Hotel commented Mar 11, 2026

Hello @jakwinkler,

Thank you for the contribution!

Please update the branch with latest changes, as we are unable to do that. After that we will pick this PR for further activites.

Thank you

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Mar 11, 2026

done

@engcom-Hotel
Copy link
Copy Markdown
Contributor

engcom-Hotel commented Mar 11, 2026

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review March 11, 2026 12:15
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Mar 11, 2026
engcom-Hotel
engcom-Hotel requested changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jakwinkler,

Thank you for your contribution!

Please have a look into the failed integration test, it seems it is failing due to the PR changes.

Thank you

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Mar 11, 2026
@engcom-Dash engcom-Dash self-assigned this Mar 12, 2026
@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Mar 16, 2026

@magento run all tests

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Mar 17, 2026

Hello @jakwinkler,

Thank you for your contribution!

Please have a look into the failed integration test, it seems it is failing due to the PR changes.

Thank you

@engcom-Hotel @jakwinkler, Since this PR has been pending for quite some time, I will address the review comments.

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Mar 17, 2026

I do not have a complete integration test suite installed to replicate this.
The code change is so small that even by "naked eye" one can rate it works and fixes the issues.
It is already merge into mageOS.

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Mar 18, 2026

Hello @jakwinkler
Thank you for your response. I have fixed the integration issue on my end. However, I’m unable to push the changes directly to this branch due to permission restrictions.

image

Could you please provide access to this branch?

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Mar 18, 2026

Can I grant you permissions to that branch on my repo?

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Mar 18, 2026

@jakwinkler, could you please grant access to the branch so I’m able to push the changes?

@jakwinkler
Copy link
Copy Markdown
Contributor Author

jakwinkler commented Mar 30, 2026

@engcom-Dash I invited you with a WRITE role to my repository.

@hostep
Copy link
Copy Markdown
Contributor

hostep commented Mar 31, 2026

@jakwinkler: that's probably not what was needed, what @engcom-Dash was asking for, is to enable the checkbox 'Allow edits by maintainers' which should be displayed in the right sidebar here in this pull request, it should be at the bottom of the sidebar underneath the list of 'participants'.

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Apr 1, 2026

@magento run all tests

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Apr 2, 2026

@magento run all tests

@engcom-Dash
Copy link
Copy Markdown
Contributor

engcom-Dash commented Apr 2, 2026

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

+1 more reviewer

@rhoerr rhoerr rhoerr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@engcom-Dash engcom-Dash

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Community Dashboard
Status: Changes Requested

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jakwinkler @engcom-Hotel @engcom-Dash @hostep @rhoerr @engcom-Bravo @engcom-Charlie