Fix stripped-min-length check #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$(value).text() is wrong in here. Actually this will evaluate to $("someinputtext").text() where $("someinputtext") is an empty object and therefor the check will always return false as the upcoming method .text() returns an empty string.
$(element) is the input element.
|
Wonder if this will get merged before we we-run the Travis checks?! Two checks failed due to some query execution/connection errors. Can someone please restart the Travis build? Thanks. |
|
Restarted the build. The other days builds failed because of "System going down for reboot" notices :D |
|
Thanks @Vinai :) |
|
Hi @avoelkl Thanks for contributing! Our internal ticket - MAGETWO-55217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(value).text()is wrong in here. Actually this will evaluate to$("someinputtext").text()where$("someinputtext")is an empty object and therefor the check will always return false as the upcoming method.text()returns an empty string.$(element)is the input element and it needs.val()to retrieve the text from the input element.